test: improve emissions module coverage #1955
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1955 +/- ##
===========================================
+ Coverage 54.00% 55.17% +1.17%
===========================================
Files 241 241
Lines 13535 13537 +2
===========================================
+ Hits 7309 7469 +160
+ Misses 5779 5624 -155
+ Partials 447 444 -3
|
skosito
changed the title
skosito
commented
Mar 28, 2024
skosito
commented
Mar 28, 2024
skosito
requested review from
brewmaster012,
kingpinXD,
kevinssgh,
fadeev,
lumtis and
ws4charlie
as code owners
kingpinXD
reviewed
Mar 28, 2024
kingpinXD
reviewed
Mar 28, 2024
kingpinXD
reviewed
Mar 28, 2024
kingpinXD
approved these changes
Apr 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Improves coverage for emissions module from 52.49% to 91.83%. Only uncovered file is
types/events.go, but i think it should be moved one level above next to abci.go, because those events are used there and not in types?Closes: #1741
Type of change
Tests
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Include instructions and any relevant details so others can reproduce.
Checklist: